Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the possibility to set a custom domain #69

Merged
merged 3 commits into from
Sep 8, 2021
Merged

Add the possibility to set a custom domain #69

merged 3 commits into from
Sep 8, 2021

Conversation

PatrikElfstrom
Copy link

Pull Request Details

Related Issue

#68

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation or my changes dont require it.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes (or the existing one were enough).
  • All new and existing tests passed.

@PatrikElfstrom
Add the possibility to set a custom domain
e08fa71 
Set a custom domain by setting the DOMAIN environment variable.
daquinoaldo
daquinoaldo reviewed Sep 8, 2021
View reviewed changes
Copy link
Owner

@daquinoaldo daquinoaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you very much! Just a minor comment and we can merge it soon! 🙌

README.md Outdated Show resolved Hide resolved
daquinoaldo
daquinoaldo approved these changes Sep 8, 2021
View reviewed changes
Copy link
Owner

@daquinoaldo daquinoaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll release it in a few days. Thank you for contributing! 🙌

@daquinoaldo daquinoaldo self-assigned this Sep 8, 2021
@daquinoaldo daquinoaldo merged commit 3c8ed5f into daquinoaldo:master Sep 8, 2021
@daquinoaldo
Copy link
Owner

Released v4.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daquinoaldo daquinoaldo daquinoaldo approved these changes

Assignees

@daquinoaldo daquinoaldo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PatrikElfstrom @daquinoaldo