Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenating two skymodels with different formats gives mixed format #36

Open
cgroeneveld opened this issue Nov 15, 2022 · 1 comment

Comments

@cgroeneveld
Copy link

Concatenating two skymodels with different formats (name - patch -type vs name - type - patch) will return a mixed-format file (which will cause issues when reading). In particular, the skymodel itself seems to be fine but the "default" line differs in format from the rest of the file.

I concatenated the files by loading both in with lsmtool.load() and then concatenate with .concatenate().

Attached are the skymodel files (3C196.skymodel.txt and Ateam.skymodel.txt are concatenated into output.skymodel.txt).

Thanks in advance!
Christian Groeneveld
output.skymodel.txt
Ateam.skymodel.txt
3C196.skymodel.txt

@darafferty
Copy link
Owner

Thanks for reporting this. Unfortunately, I wasn't able to reproduce the issue with the incorrect format line. However, I did note that there was an issue with the LogarithmicSI column in your output sky model (values of -999 instead of "true"). This issue has now been fixed on the current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants