Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webm (libvpx) changes #80

Closed
wants to merge 3 commits into from
Closed

Webm (libvpx) changes #80

wants to merge 3 commits into from

Conversation

ggarra13
Copy link
Contributor

@ggarra13 ggarra13 commented Feb 1, 2023

This change adds libvpx support to CI, FFmpeg build as well as tlRender's extension support.
This is a simple PR to link the libvpx library dynamically. But in fact, it should be built statically.

@ggarra13 ggarra13 closed this Feb 1, 2023
@ggarra13 ggarra13 reopened this Feb 1, 2023
@ggarra13
Copy link
Contributor Author

ggarra13 commented Feb 1, 2023

This is a simple PR to link the libvpx library dynamically. But in fact, it should be built statically.

@darbyjohnston
Copy link
Owner

Doesn't this create a dependency on libvpx being installed on the system?

@ggarra13
Copy link
Contributor Author

ggarra13 commented Feb 1, 2023

Yes. That's why I mentioned linking them dynamically for now.

This is for you to try on a separate branch, on Linux or macOS to see the video going black.

The dependencies on Linux and macOS are a non issue as you have apt-get and brew.
On Windows, it is also not an issue if you use the media-autobuild_suite which installs Msys, compiles everything for you statically and compiles FFmpeg dynamically. It is much better than using WSL2 as you did.
I am currently updating the documentation on mrv2's README.md about that.

@ggarra13
Copy link
Contributor Author

ggarra13 commented Feb 8, 2023

Don't worry about it. I remembered I have BuildYASM.cmake and BuildVPX.cmake files in mrViewer 1 (those are the two dependencies needed to compile webm/libvps).
I'll move them over to my own tlRender copy and I'll do a proper PR with them and with an set( TLRENDER_VPX OFF ) by default so you don't have to compile it if you don't want it.

@ggarra13 ggarra13 closed this Feb 8, 2023
@ggarra13 ggarra13 deleted the webm branch February 8, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants