Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(real) Change forceload to ignore naturally generated chest minecarts #7

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

catgirlsky
Copy link
Contributor

fix issue #5
Only execute the forceload command if the chest minecart doesn't have the "abandoned_mineshaft" loot table, which indicates it was naturally spawned in. Should significantly reduce server lag. :3

@darceno
Copy link
Owner

darceno commented Apr 25, 2024

What a great work! I've spent some afternoons trying to solve this problem without getting anywhere. I thought about several alternative workarounds, but I completely forgot about loot tables.

I'll credit your GitHub account in the changelog of the next version on Modrinth, as well as in the main page (if you're okay with that. If anything just let me now).

Thank you, I appreciate it :D

@darceno darceno merged commit d0beeb8 into darceno:main Apr 25, 2024
@darceno darceno linked an issue Apr 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minecart Chests from mineshafts appear to load chunks as well
2 participants