Resolution for: Elements#select should return generically typed Select element #64 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you're missing imports |
| import com.redhat.darcy.ui.api.elements.Select; | ||
| import com.redhat.darcy.ui.api.elements.Text; | ||
| import com.redhat.darcy.ui.api.elements.TextInput; | ||
| import com.redhat.darcy.ui.api.elements.*; |
There was a problem hiding this comment.
We've avoided * imports as a matter of style to be explicit; let's keep that rule I think. You may have to configure your IDE to avoid * imports.
| @@ -22,6 +22,8 @@ | |||
| import com.redhat.darcy.ui.api.HasElementContext; | |||
| import com.redhat.darcy.ui.api.Locator; | |||
| import com.redhat.darcy.ui.api.WrapsElement; | |||
| import com.redhat.darcy.ui.internal.ElementHandler; | |||
| import com.redhat.darcy.ui.internal.ElementListHandler; | |||
There was a problem hiding this comment.
The ordering should be alphabetical, but I'll let it slide ;)
|
LGTM! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to 'select()' within ElementSelection.java & Elements.java