Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality fix - "equals(Object obj)" and "hashCode()" should be overridden in pairs. #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Code quality fix - "equals(Object obj)" and "hashCode()" should be overridden in pairs. #69

wants to merge 1 commit into from

Conversation

faisal-hameed
Copy link
Contributor

This pull request is focused on resolving occurrences of Sonar rule
squid:S1206- "equals(Object obj)" and "hashCode()" should be overridden in pairs
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1206

Please let me know if you have any questions.

Faisal Hameed

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 31.713% when pulling 3bedd87 on DevFactory:release/equals-and-hashcode-should-be-overriden-in-pairs-fix-1 into d074b3a on darcy-framework:master.

@alechenninger
Copy link
Member

Hi Faisal, thanks for the PR. Would you mind updating these equals() implementations to use Objects.equals(.., ...) instead? Also, I prefer not to see if blocks without braces.

I try to follow https://google.github.io/styleguide/javaguide.html except we use 4 space tabs. The point of note here is https://google.github.io/styleguide/javaguide.html#s4.1.1-braces-always-used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants