Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Open All button should display a message on hover #29

Closed
Jiehong opened this issue Jan 12, 2022 · 13 comments
Closed

The Open All button should display a message on hover #29

Jiehong opened this issue Jan 12, 2022 · 13 comments
Assignees
Labels
good first issue Good for newcomers Type: Enhancement New feature or request

Comments

@Jiehong
Copy link

Jiehong commented Jan 12, 2022

Hi,

The "open all" button for each category has an aria-label, which is great, but is missing a title:

<button type="button" class="btn-unstyled" aria-label="Open all links from this bucket" tabindex="-1">
  <div class="icon icon-open-all"></div>
</button>

Having a title would allow a on-hover element to be shown for sighter users:

<button type="button" class="btn-unstyled" aria-label="Open all links from this bucket" tabindex="-1" title="Open all links from this bucket">
  <div class="icon icon-open-all"></div>
</button>
@darekkay darekkay added good first issue Good for newcomers Type: Enhancement New feature or request labels Jan 12, 2022
@RishiKumarRay
Copy link

Can I work on this changes, assign me

@RishiKumarRay
Copy link

Can you guide me, where the files are present so that i can make the changes

@darekkay
Copy link
Owner

@RishiKumarRay
Copy link

@darekkay Can you check this , is the changes fine?
Screenshot from 2022-01-12 22-23-15
just added title

@RishiKumarRay
Copy link

If you approve i will raise PR

@darekkay
Copy link
Owner

Yes, looks good to me

@RishiKumarRay
Copy link

fixed and raise PR

@darekkay
Copy link
Owner

darekkay commented Jan 13, 2022

PR merged: darekkay/static-marks-app#3

Repository owner deleted a comment from allcontributors bot Jan 13, 2022
Repository owner deleted a comment from allcontributors bot Jan 13, 2022
@darekkay
Copy link
Owner

@all-contributors please add @RishiKumarRay for maintenance

@allcontributors
Copy link
Contributor

@darekkay

I've put up a pull request to add @RishiKumarRay! 🎉

@darekkay
Copy link
Owner

@all-contributors please add @Jiehong for maintenance

@allcontributors
Copy link
Contributor

@darekkay

I've put up a pull request to add @Jiehong! 🎉

@darekkay
Copy link
Owner

Released in 2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants