fix: contain all page content in landmarks

dargmuesli · Sep 14, 2023 · 6900320 · 6900320
1 parent d057b0b
commit 6900320
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 19 deletions.
diff --git a/src/pages/index.vue b/src/pages/index.vue
@@ -1,23 +1,25 @@
 <template>
   <div class="flex flex-col xl:flex-row">
-    <nuxt-img
-      alt="Jonas in Tutzing."
-      class="xl:fixed"
-      :class="imageClasses"
-      fetchpriority="high"
-      format="webp"
-      preload
-      src="/assets/static/images/tutzing.jpg"
-    />
-    <nuxt-img
-      alt="Jonas in Tutzing."
-      class="hidden xl:block"
-      :class="imageClasses"
-      fetchpriority="high"
-      format="webp"
-      preload
-      src="/assets/static/images/tutzing.jpg"
-    />
+    <aside>
+      <nuxt-img
+        alt="Jonas in Tutzing."
+        class="xl:fixed"
+        :class="imageClasses"
+        fetchpriority="high"
+        format="webp"
+        preload
+        src="/assets/static/images/tutzing.jpg"
+      />
+      <nuxt-img
+        alt="Jonas in Tutzing."
+        class="hidden xl:block"
+        :class="imageClasses"
+        fetchpriority="high"
+        format="webp"
+        preload
+        src="/assets/static/images/tutzing.jpg"
+      />
+    </aside>
     <div class="p-4 sm:p-8">
       <main class="min-w-0 space-y-6 pb-32 xl:min-h-screen">
         <div class="flex items-center justify-between">

diff --git a/src/tests/e2e/specs/pages/root/index.spec.ts b/src/tests/e2e/specs/pages/root/index.spec.ts
@@ -34,7 +34,17 @@ test.describe('a11y', () => {
     await page.goto('/')
     await PAGE_READY({ page })
     const accessibilityScanResults = await new AxeBuilder({ page }).analyze()
-    expect(accessibilityScanResults.violations.length).toEqual(1) // TODO: get rid of all violations
+    // expect(
+    //   accessibilityScanResults.violations
+    //     .map(
+    //       (x) =>
+    //         `${x.id}\n${x.nodes.map(
+    //           (y) => `${y.failureSummary}\n(${y.html})`,
+    //         )}`,
+    //     )
+    //     .join('\n'),
+    // ).toEqual('')
+    expect(accessibilityScanResults.violations.length).toEqual(0)
   })
 })