Skip to content

Commit

Permalink
feat(root): add label to aside
Browse files Browse the repository at this point in the history
  • Loading branch information
dargmuesli committed Sep 23, 2023
1 parent c29445f commit a7c98f1
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 11 deletions.
4 changes: 3 additions & 1 deletion src/pages/index.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div class="flex flex-col xl:flex-row">
<aside class="relative flex">
<aside :aria-label="t('asideLabel')" class="relative flex">
<div
class="flex aspect-[2081/3009] max-h-[80vh] flex-1 xl:fixed xl:h-[100vh] xl:max-h-[none] xl:max-w-[50vw]"
>
Expand Down Expand Up @@ -514,6 +514,7 @@ de:
aboutMarkDj: DJ und Event-Organisator
aboutMarkSoftware: Leidenschaftlicher Software-Entwickler
aboutSidefact: Freundet sich mit der Mitte von Schwarz und Weiß an, hodlt nebenbei.
asideLabel: Titelbild
ccc: Chaos Computer Club
cccTimespan: Mai 2018 – {present}
contactForm: Kontaktformular
Expand Down Expand Up @@ -571,6 +572,7 @@ en:
aboutMarkDj: DJ and event organizer
aboutMarkSoftware: Passionate software developer
aboutSidefact: Getting used to the middle of black and white, hodling in the meantime.
asideLabel: Title image
ccc: Chaos Computer Club
cccTimespan: May 2018 – {present}
contactForm: Contact form
Expand Down
20 changes: 10 additions & 10 deletions src/tests/e2e/specs/pages/root/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,16 @@ test.describe('a11y', () => {
await page.goto('/')
await PAGE_READY({ page })
const accessibilityScanResults = await new AxeBuilder({ page }).analyze()
// expect(
// accessibilityScanResults.violations
// .map(
// (x) =>
// `${x.id}\n${x.nodes.map(
// (y) => `${y.failureSummary}\n(${y.html})`,
// )}`,
// )
// .join('\n'),
// ).toEqual('')
expect(
accessibilityScanResults.violations
.map(
(x) =>
`${x.id}\n${x.nodes.map(
(y) => `${y.failureSummary}\n(${y.html})`,
)}`,
)
.join('\n'),
).toEqual('')
expect(accessibilityScanResults.violations.length).toEqual(0)
})
})
Expand Down

0 comments on commit a7c98f1

Please sign in to comment.