Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(component): cookie toggles do not show the correct state when isIframeBlocked is enabled #115

Closed
StefanFlaschko opened this issue Aug 13, 2023 · 1 comment · Fixed by #117
Closed

fix(component): cookie toggles do not show the correct state when isIframeBlocked is enabled #115

StefanFlaschko opened this issue Aug 13, 2023 · 1 comment · Fixed by #117
Assignees
@dargmuesli
Labels
bug Something isn't working

Comments

@StefanFlaschko
Copy link

StefanFlaschko commented Aug 13, 2023 •
edited
Loading

Environment

It was tested in the playground of the repo.

Reproduction

It was tested in the playground of the repo.

Describe the bug

When Setting the toggle for optional cookies to disable and reloading the page, the toggle still shows active.
What I also recognized is that the values inside the cookie: 'ncc_c' are not using any separators. (intentional ?)

Video:
https://github.com/dargmuesli/nuxt-cookie-control/assets/60323626/3f799f5a-59b7-497d-9a7c-3b132b443126

Additional context

No response

Logs

No response
@dargmuesli dargmuesli changed the title Cookie Options Toggle shows active after setting it to disabled and reloading the page. fix(component): cookie toggles do not show the correct state when isIframeBlocked is enabled Aug 14, 2023
@dargmuesli dargmuesli added the bug Something isn't working label Aug 14, 2023
@dargmuesli dargmuesli self-assigned this Aug 14, 2023
dargmuesli added a commit that referenced this issue Aug 14, 2023
@dargmuesli
fix(components): do not add show all optional cookies as enabled when…
c8fe070 
… `isIframeBlocked` is enabled

Resolves #115
@dargmuesli dargmuesli mentioned this issue Aug 14, 2023
Merged
2 tasks
dargmuesli added a commit that referenced this issue Aug 14, 2023
@dargmuesli
fix(components): do not add show all optional cookies as enabled when…
6af3a1c 
… `isIframeBlocked` is enabled (#117)

Resolves #115
@dargmuesli
Copy link
Owner

Thank you for mentioning this case! The fix should be released shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dargmuesli dargmuesli

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@dargmuesli @StefanFlaschko