Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): types generator and CookieID string literal #210

Merged
merged 2 commits into from
May 7, 2024

Conversation

BlueBazze
Copy link
Contributor

@BlueBazze BlueBazze commented May 3, 2024

PR for #209

📚 Description

Typing for projects' cookies.

A nice to have feature.
Allowing the users to type their cookie references.
And might be able to be used as typing for cookiesEnabledIds etc..

Also added a nuxt hook listener to update the templates when the nuxt config is being updated while the dev server is running.

📝 Checklist

  • All commits follow the Conventional Commit format
  • The PR's title follows the Conventional Commit format
  • Can build successfully
  • Does not introduce breaking changes

@BlueBazze
Copy link
Contributor Author

I tried making sure the module would could build correctly.
But the following error was thrown.

 ERROR  Cannot find module '/home/tbj/Documents/nuxt-cookie-control/dist/runtime/types' imported from /home/tbj/Documents/nuxt-cookie-control/dist/module.mjs                                              11:56:23 AM
  at finalizeResolution (node:internal/modules/esm/resolve:264:11)
  at moduleResolve (node:internal/modules/esm/resolve:924:10)
  at defaultResolve (node:internal/modules/esm/resolve:1148:11)
  at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:390:12)
  at ModuleLoader.resolve (node:internal/modules/esm/loader:359:25)
  at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:234:38)
  at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:87:39)
  at link (node:internal/modules/esm/module_job:86:36)

Tried checking out to the current master commit, and the same error was thrown.
So i don't believe this is caused by anything i committed.

Copy link
Owner

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! 💚

src/generator/typesGenerator.ts Outdated Show resolved Hide resolved
@dargmuesli dargmuesli merged commit 22796c3 into dargmuesli:master May 7, 2024
12 checks passed
dargmuesli-bot pushed a commit that referenced this pull request May 7, 2024
## [8.2.0](8.1.4...8.2.0) (2024-05-07)

### Features

* **types:** types generator and CookieID string literal ([#210](#210)) ([22796c3](22796c3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants