fix: don't include css-vars-ponyfill chunk if not enabled
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dargmuesli
approved these changes
Mar 1, 2023
|
You're amazing, Daniel! Thank you so much for showing how to do this. 鉂わ笍 I've really learned something 馃檹 |
|
馃帀 This PR is included in version 5.0.1 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摎 Description
This is how you would ensure that you don't accidentally create a chunk if the user doesn't want the feature enabled. Accessing
moduleOptionsisn't ideal because it's not static enough for rollup or vite to know the value exists and never changes, and therefore be able to tree-shake out the contents of one-half of the if/else clause. So instead we can conditionally provide a helper file based on what the user option is.Resolves #37.
馃摑 Checklist