Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better loading performance and better panorama scrolling #89

Merged
merged 2 commits into from
Dec 31, 2020

Conversation

DanielHabenicht
Copy link
Contributor

Hi! Thanks for the great module.

I made some adaptions to make it run more smoothly:

  1. Added a custom loading handler for the images in express. (Before all images were loaded without caching, leading to loading the image three times (one for img.src, one for EXIF.getTags() and one for css url()), now the static images are loaded with a cache header of 1 hour and thus only loaded once.
  2. I also added a random scrolling for panorama pictures, now they do not only scroll from top to bottom (or left to right) but also the other way around.
  3. Lastly I formatted the files with prettier, but you don't have to use it, just makes it easier for me and more consistent.

I would be glad if you want to merge :)

 * otherwiese three seperate requests would be made which
  each load the whole picture, because max-age=0 on the MagicMirror
  server instance
  * add prettier file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants