Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter devices with ManufacturerData #127

Closed
Dionysios opened this issue Feb 1, 2017 · 3 comments
Closed

Filter devices with ManufacturerData #127

Dionysios opened this issue Feb 1, 2017 · 3 comments
Assignees
@dariuszseweryn
Labels
enhancement
Milestone
1.3.0

Comments

@Dionysios
Copy link

Summary


Hi, I am not sure if I missed somehow by the ScanBleDevices can only accept UUID as filter.
Is it possible to scan with other filters eg manufacturer data?
Thanks!

Preconditions


public abstract Observable scanBleDevices(@nullable UUID... filterServiceUUIDs);

Steps to reproduce actual result

Actual result


#### Expected result
@uKL
Copy link
Collaborator

uKL commented Feb 1, 2017

Currently there is no such feature. Feel free to contribute :)

@dariuszseweryn
Copy link
Owner

Of course it is possible to filter the devices with the manufacturer data. The thing is you have to do it manually as the library has no built-in feature. ;) This state will probably change once the Lollipop scanning API will be supported. You can still contribute to it! #74 Best Regards.

@literator literator modified the milestones: Android API 21 Compatibility, 1.2.0 Feb 2, 2017
@dariuszseweryn dariuszseweryn self-assigned this May 16, 2017
@dariuszseweryn dariuszseweryn added this to the 1.3.0 milestone May 18, 2017
dariuszseweryn added a commit that referenced this issue May 22, 2017
@dariuszseweryn
Added Support for ble Scan API level 21
66b1955 
Summary:
#16
#127

Reviewers: michal.zielinski, pawel.urban

Reviewed By: pawel.urban

Differential Revision: https://phabricator.polidea.com/D2279
@dariuszseweryn
Copy link
Owner

Just added the new scanning API to 1.3.0-SNAPSHOT. Feel free to check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dariuszseweryn dariuszseweryn

Labels
enhancement
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
4 participants
@literator @dariuszseweryn @Dionysios @uKL