Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress QueueSemaphore verbose log if released #317

Closed
dariuszseweryn opened this issue Nov 14, 2017 · 0 comments
Closed

Suppress QueueSemaphore verbose log if released #317

dariuszseweryn opened this issue Nov 14, 2017 · 0 comments
Assignees
@uKL
Labels
enhancement good first issue
Milestone
1.4.3

Comments

@dariuszseweryn
Copy link
Owner

Summary

Every time a cancelable operation is canceled a VERBOSE log is displayed with a stacktrace. When isReleased().get()==true then this log can be omitted as it only introduces confusion. If isReleased().get()==false then this log could be promoted to WARNING.

Library version

1.4.2

Steps to reproduce actual result


1. Start direct connection to a device

2. Unsubcsribe

3. Observe log
@uKL uKL self-assigned this Nov 16, 2017
@uKL uKL added this to the 1.4.3 milestone Nov 16, 2017
uKL added a commit that referenced this issue Nov 16, 2017
@uKL
[#317] Log informing that the underlying semaphore in a QueueSemaphor…
d7d4735 
…e has been interrupted will be printed only when the situation was unexpected.
uKL added a commit that referenced this issue Nov 16, 2017
@uKL
[#317] Log informing that the underlying semaphore in a QueueSemaphor…
9cf555b 
…e has been interrupted will be printed only when the situation was unexpected.
uKL added a commit that referenced this issue Nov 16, 2017
@uKL
[#317] Log informing that the underlying semaphore in a QueueSemaphor…
2ac2d2d 
…e has been interrupted will be printed only when the situation was unexpected. (#320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uKL uKL

Labels
enhancement good first issue
Projects
None yet
Milestone
1.4.3
Development

No branches or pull requests
2 participants
@dariuszseweryn @uKL