Fixed stalled client queue when adapter is off #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a race condition in ConnectorImpl which was simultaneously scheduling connecting operation and observing BT adapter being switched off. As the client operation queue runs on it’s own thread it was possible that the connecting operation would get scheduled and started but cancelled before the actual `protectedRun()` would get executed — this result in a situation where the client queue would get blocked and never released due to the operation never being run but still responsible for releasing. Workaround: start observing BT adapter state after the connecting operation finishes. The operation is observing it either way during the execution and will emit an error if BT is off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race condition in ConnectorImpl which was simultaneously scheduling connecting operation and observing BT adapter being switched off. As the client operation queue runs on it’s own thread it was possible that the connecting operation would get scheduled and started but cancelled before the actual
protectedRun()would get executed — this result in a situation where the client queue would get blocked and never released due to the operation never being run but still responsible for releasing.Workaround: start observing BT adapter state after the connecting operation finishes. The operation is observing it either way during the execution and will emit an error if BT is off
Fixes #516