Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed IllegalStateException on RxBleAdapterStateObservable #596

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Fixed IllegalStateException on RxBleAdapterStateObservable #596

merged 1 commit into from
Jun 28, 2019

Conversation

dariuszseweryn
Copy link
Owner

Setting a cancelable on an Emitter did run it immediately if it was already disposed. Postponing the setting until after the BroadcastReceiver is registered fixed the issue.

Fixes #592

@dariuszseweryn dariuszseweryn added the bug Bug that is caused by the library label Jun 28, 2019
@dariuszseweryn dariuszseweryn added this to the 1.10.1 milestone Jun 28, 2019
@dariuszseweryn dariuszseweryn self-assigned this Jun 28, 2019
@dariuszseweryn dariuszseweryn merged commit f19f46f into master Jun 28, 2019
@dariuszseweryn dariuszseweryn deleted the fix/adapter_state_obs_illegalstateexception branch June 28, 2019 16:30
@ened
Copy link
Contributor

ened commented Jun 29, 2019

Thank you! Could you cut a release?

@dariuszseweryn
Copy link
Owner Author

I already did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dariuszseweryn dariuszseweryn

Labels
bug Bug that is caused by the library
Projects
None yet
Milestone
1.10.1
Development

Successfully merging this pull request may close these issues.

Receiver not registered
2 participants
@dariuszseweryn @ened