Fixed https://github.com/Polidea/RxAndroidBle/issues/60 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,6 +76,12 @@ public void addAdvertisedUUID(UUID advertisedUUID) { | |||
| } | |||
|
|
|||
| @Override | |||
| public BluetoothDevice getBluetoothDevice() { | |||
There was a problem hiding this comment.
is this change of places needed?
There was a problem hiding this comment.
No, just autoformatter. Do you want me to revert it to the previous state?
There was a problem hiding this comment.
Yes, for pull requests these reorderings only make it worse to read. For refactorings that are not changing code but only reordering - you can push directly.
|
Done, also I've rebased to current master in order to avoid checkstyle fail due to an unused import in other part of the library. |
|
Rebased and merged into master ( f1a67da ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection was emitted incorrectly in
establishConnectionmethod. Observable was callingonCompleteafter emission which then caused thatdoOnUnsubscribe. This is the reason thatDISCONNECTEDstate was emitted every time, and it should only be emitted after explicit unsubscription from connection observable.