Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Construct scanrecord bytes #712

Merged
merged 3 commits into from Dec 11, 2020
Merged

Construct scanrecord bytes #712

merged 3 commits into from Dec 11, 2020

Conversation

nrbrook
Copy link
Contributor

@nrbrook nrbrook commented Aug 15, 2020

Based on #707.
Implements construction of the mock scan record's bytes

@dariuszseweryn
Copy link
Owner

Could you merge current master to both current PRs?

@nrbrook
Copy link
Contributor Author

nrbrook commented Aug 24, 2020

Done!

@dariuszseweryn
Copy link
Owner

This does not look like it is in any way connected to #711 right?

@nrbrook
Copy link
Contributor Author

nrbrook commented Oct 27, 2020

This does not look like it is in any way connected to #711 right?

No, it isn't

dariuszseweryn
dariuszseweryn approved these changes Dec 11, 2020
View reviewed changes
Copy link
Owner

@dariuszseweryn dariuszseweryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dariuszseweryn dariuszseweryn merged commit 7bcb37b into dariuszseweryn:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariuszseweryn dariuszseweryn dariuszseweryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nrbrook @dariuszseweryn