Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added repeat-attack to the productivity folder #12

Merged
merged 13 commits into from Jan 2, 2021

Conversation

Bind
Copy link
Contributor

@Bind Bind commented Dec 31, 2020

No description provided.

Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is FANTASTIC. Just a couple things, the only big one being the requirement to not use any import that could easily be swapped out.

content/productivity/repeat-attack/plugin.js Outdated Show resolved Hide resolved
content/productivity/repeat-attack/plugin.js Show resolved Hide resolved
content/productivity/repeat-attack/plugin.js Show resolved Hide resolved
content/productivity/repeat-attack/plugin.js Outdated Show resolved Hide resolved
content/productivity/repeat-attack/plugin.js Outdated Show resolved Hide resolved
Bind and others added 2 commits December 31, 2020 14:09
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
- update import path
- Add Core Lib to /utils
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Bind and others added 3 commits December 31, 2020 18:05
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
this.f = this.flood.bind(this);
}
storeActions() {
window.localStorage.setItem(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, nice!

@phated
Copy link
Contributor

phated commented Jan 1, 2021

Finally finished my review. Lots of awesome stuff in here. Going to run this locally a little bit to test it myself and then I'll merge. Amazing work!

@phated
Copy link
Contributor

phated commented Jan 1, 2021

@Bind I just set up a repeating attack but it doesn't show up in the "Recurring Attacks" section. I even tried refreshing that list. Is there a bug with that?

@phated
Copy link
Contributor

phated commented Jan 1, 2021

Closing and re-opening the plugin gets it to show up 🤔

@Bind
Copy link
Contributor Author

Bind commented Jan 1, 2021

Hmm will fix that push up changes later tonight

@Bind
Copy link
Contributor Author

Bind commented Jan 2, 2021

Give that a shot!

Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@phated phated merged commit e20e6f4 into darkforest-eth:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants