New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added repeat-attack to the productivity folder #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is FANTASTIC. Just a couple things, the only big one being the requirement to not use any import that could easily be swapped out.
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
a76b84e
to
adb65c3
Compare
- update import path - Add Core Lib to /utils
adb65c3
to
edfc901
Compare
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
this.f = this.flood.bind(this); | ||
} | ||
storeActions() { | ||
window.localStorage.setItem( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, nice!
Finally finished my review. Lots of awesome stuff in here. Going to run this locally a little bit to test it myself and then I'll merge. Amazing work! |
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
@Bind I just set up a repeating attack but it doesn't show up in the "Recurring Attacks" section. I even tried refreshing that list. Is there a bug with that? |
Closing and re-opening the plugin gets it to show up 🤔 |
Hmm will fix that push up changes later tonight |
Give that a shot! |
…bind/repeat-attack
f491d39
to
ddb3426
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
No description provided.