Feat/centralize ressources #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
approved these changes
May 29, 2021
There was a problem hiding this comment.
Interesting! 1 thing I wanted to point out is that you are checking all planets within the distance of your target planet, which means they might not have enough range/etc on them to fill it. Additionally, you might be missing a planet out of range that could fill it up.
However, doing it by iterating all your planets and running the planetsInRange call is very expensive, so this could still be useful for people.
phated
reviewed
May 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new plugin to collect energy and silver from close planets to your selected planet.
V0.1. Suggestions are welcome
Current implementation checks for the closest planet 1st and ignore any senders that can't give more than 1% of the max energy of the requesting planet