Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analysis not handling Secrets well #4127

Closed
StachuDotNet opened this issue Jun 11, 2022 · 5 comments
Closed

Analysis not handling Secrets well #4127

StachuDotNet opened this issue Jun 11, 2022 · 5 comments
Assignees
@StachuDotNet

Comments

@StachuDotNet
Copy link
Member

An Analysis request of a REPL with a simple Secret returns Incomplete currently
@StachuDotNet StachuDotNet self-assigned this Jun 11, 2022
@StachuDotNet
Copy link
Member Author

StachuDotNet commented Jun 11, 2022 •
edited

Some potential failure points to check:

  • at deserialization
  • during conversion to OCaml types
  • during eval/Interpeter
  • during serialization (Vanilla handles secrets poorly?)

@StachuDotNet
Copy link
Member Author

StachuDotNet commented Jun 11, 2022 •
edited

The issue is happening during Exe.executeExpr somewhere (that's where secrets disappear and turn into Incompletes)

@StachuDotNet
Copy link
Member Author

secrets = [] :)

@StachuDotNet
Copy link
Member Author

Should have a bug fix shortly

@StachuDotNet StachuDotNet mentioned this issue Jun 11, 2022
Merged
@StachuDotNet
Copy link
Member Author

This was resolved by #4128.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StachuDotNet StachuDotNet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StachuDotNet