Pass secrets through in F# analysis #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StachuDotNet
commented
Jun 11, 2022
Comment on lines
+676
to
+677
| let ocamlSecret2RT (secret : secret) : RT.Secret.T = | ||
| { name = secret.secret_name; value = secret.secret_value } |
There was a problem hiding this comment.
I was slightly surprised to see a RT value here rather than a PT value, but that's what's expected by analysis.
|
will fix #4127 |
|
Edit: I was wrong, it doesn't. And I've confirmed consistent results in how we hide the values of the passwords, across Wasm.fs and js_of_ocaml. (using |
|
My confidence here is high, and it's a regression from the old analysis, so merging this. |
|
Follow-up: #4129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty list
[]of Secrets is currently being passed through for F# analysis. This fixes that.