Add --loop flag to integration tests #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a bit nitpicky, but could we have |
Ah, I can see why you ask, but alas |
|
Ah, I see - confusing! |
pbiggar
force-pushed
the
paul/loop-integration-tests
branch
from
bebf70d
to
64fd7ed
Compare
pbiggar
force-pushed
the
paul/loop-integration-tests
branch
from
64fd7ed
to
942239c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
By looping the integration tests with
--loop, we can find flaky tests. Often it takes 4-15 loops to find a flaky one. It's also really useful to combine with--pattern, to debug one test that you know if flaky