Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source code formatting check isn't running on CI #123

Closed
Dean177 opened this issue May 18, 2020 · 1 comment · Fixed by #125
Closed

Source code formatting check isn't running on CI #123

Dean177 opened this issue May 18, 2020 · 1 comment · Fixed by #125
Assignees
@Dean177

Comments

@Dean177
Copy link
Collaborator

Dean177 commented May 18, 2020

Its a false positive right now: https://circleci.com/gh/darklang/tablecloth/549

The following is printed on the make check-format step
/bin/sh: 1: fd: not found
@Dean177
Copy link
Collaborator Author

Dean177 commented May 19, 2020

I resolved this in https://github.com/Dean177/tablecloth/tree/fix-formatting-commands, but it depends upon #124 . Once that gets merged I will open a PR

@Dean177 Dean177 self-assigned this May 19, 2020
@Dean177 Dean177 mentioned this issue May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dean177 Dean177

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix formatting commands Dean177/tablecloth
1 participant
@Dean177