Fixed exception when menu config is Unicode #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the menu config is Unicode (e.g. `from __future__ import unicode_literals` or `u'string'`), the Suit menu will trigger an exception. Tested on Python 2.7 with Django 1.6.
|
As you can see travis tests with Django 1.4 failed, because One option is to refactor conditions to try:
basestring
except NameError:
basestring = (str, bytes)Or raise minimum requirements to 1.4.2. |
|
Ah right. Haven't had to deal with Django 1.4 in a while! Fixed in 95ba602 |
darklow
added a commit
that referenced
this pull request
Mar 11, 2014
Fixed exception when menu config is Unicode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the menu config is Unicode (e.g.
from __future__ import unicode_literalsoru'string'), the Suit menu will trigger an exception. Tested on Python 2.7 with Django 1.6.