Fixed issue where SortableGenericInlines would break whenever adding blank inline forms #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blank inline forms. This is because inline fieldset names append the names of the generic relation fields as defined in models.py. For instance, instead of being called "model_set-n-field" they'd be called "app-model-content_type-object_id-n-field" reflecting the names of the generic type and id fields. I replaced the string split on '-' with a regexp split that looks for the -n- pattern instead. This appears to work in Chrome for both regular and generic relations.
Previously sortable.js was unable to detect whether or not a checkbox had deviated from its original value. First of all the test to find non-blank values:
$set_block.find(":input[value!=''][type!='hidden']")
would not work on a checkbox, since its value will evaluate to "on" or "off".
Secondly, the function filter_unchanged only handled select boxes and the sortable field. As a result, a checkbox in an inline form would always flag a row as "changed". This is particularily troublesome when you have extra blank forms in a formset.
The fix was to add a block in filter_unchanged to check for a checkbox field, and compare its current checked property to that of defaultChecked.
|
Added another fix for checkbox support in sortable inlines |
|
Thank you for the fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because inline fieldset names append the names of the generic relation fields as defined in models.py. For instance, instead of being called "model_set-n-field" they'd be called
"app-model-content_type-object_id-n-field" reflecting the names of the generic type and id fields. I replaced the string split on '-' with a regexp split that looks for the -n- pattern instead.
This appears to work in Chrome for both regular and generic relations.