Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #710 - Remove admin_static template tag in favor of static #711

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Fix #710 - Remove admin_static template tag in favor of static #711

merged 1 commit into from
Jan 10, 2020

Conversation

amureki
Copy link
Contributor

@amureki amureki commented Nov 2, 2018

Hi,

this is my attempt to fix #710

admin_static tag was deprecated since 2.1 and before was representing the same static tag.
So, I believe, we can safely replace it to remove deprecation warnings.

@amureki
Copy link
Contributor Author

amureki commented Oct 31, 2019

@darklow hey Kaspars!

Sorry to bother you.
Do you think we can get this going?
I now realised, I opened a patch against v2 branch, while it should be fixed in master. Do you want me to update it?
I'd be happy to fix it in both branches!

Best,
Rust

Copy link

@geceba geceba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change resolves the problem with admin_static and works with django 3.0

@darklow darklow merged commit 0d854c9 into darklow:v2 Jan 10, 2020
@darklow
Copy link
Owner

darklow commented Jan 10, 2020

Merged in. @amureki @geceba Thank you.

@geceba geceba mentioned this pull request Jan 10, 2020
51 tasks
@CARocha
Copy link

CARocha commented Jun 17, 2020

Hi, i am used django 2.2.13 and django suit 0.2.28 i still warning RemovedInDjango30Warning: {% load staticfiles %} is deprecated in favor of {% load static %}.
RemovedInDjango30Warning,

any solution for this error, i need fix this warning please any advice!

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemovedInDjango30Warning: {% load admin_static %} is deprecated
4 participants