Incorrect regex causes failure - Record NSEC3 - write_db

[FrankSpierings]

Line 782 of dnsrecon.py will process NSEC3 records, which results in a stacktrace as shown below:

Traceback (most recent call last):
File "dnsrecon.py", line 1666, in
main()
File "dnsrecon.py", line 1638, in main
write_db(results_db, returned_records)
File "dnsrecon.py", line 784, in write_db
'values( "%(type)s", "%(target)s", "%(address)s" )' % n
KeyError: 'target'

Suggestion for a fix (line 782):
elif re.match(r'NS$', n['type']):

[darkoperator]

will get to ll the issues you opened tonight :) Thanks for reporting the issues.

[FrankSpierings]

That would be great! I would love to be able to consistently use the tool during pentests. Saves me all the manual 'dig' labour ;)

[FrankSpierings]

This is fixed when using sqlite as output. I'm also testing csv and xml output. This should be the fix for a similar problem in csv output.

@@ -715,7 +715,7 @@ def make_csv(data):
             if re.search(r'PTR|^[A]$|AAAA', n['type']):
                 csv_data += n['type'] + "," + n['name'] + "," + n['address'] + "\n"

-            elif re.search(r'NS', n['type']):
+            elif re.search(r'NS$', n['type']):
                 csv_data += n['type'] + "," + n['target'] + "," + n['address'] + "\n"

             elif re.search(r'SOA', n['type']):

[FrankSpierings]

The issue for xml is different. I'll open another ticket.

[darkoperator]

Fix applied and tested.

On Feb 14, 2015, at 7:30 AM, FrankSpierings notifications@github.com wrote:

The issue for xml is different. I'll open another ticket.

—
Reply to this email directly or view it on GitHub #27 (comment).

[FrankSpierings]

Confirmed, closing ticket.