Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies to setup.py #242

Merged
merged 2 commits into from May 16, 2023
Merged

Add dependencies to setup.py #242

merged 2 commits into from May 16, 2023

Conversation

austintraver
Copy link
Contributor

Currently, when installing dnsrecon via

pip install 'dnsrecon @ git+https://github.com/darkoperator/dnsrecon@1.1.4'

Invocations of dnsrecon fail if the lxml package is not installed.

This PR updates setup.py to include dnsrecon's required dependencies, in order to ensure it runs successfully when the command is installed in this fashion.

@L1ghtn1ng
Copy link
Collaborator

Can you change the install_requires to use the package variable as that should then pull stuff from the requirements.txt

@austintraver
Copy link
Contributor Author

I couldn't figure out how to do so using the package variable, but I did find a way to pull stuff from the requirements.txt file by adding a line to setup.cfg instead. I tested the installation and can confirm that the dependencies specified in requirements.txt get installed.

@L1ghtn1ng
Copy link
Collaborator

Thanks for this

@L1ghtn1ng L1ghtn1ng merged commit fedf926 into darkoperator:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants