-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working in PDF viewing #374
Comments
This is currently working for me again, mark as resolved? |
This is working for me only in Filter/Filter+ in Chrome and Vivaldi (on Chromium). |
Firefox viewer seems to be invertable. Chrome one is all in one component, it will be tricky to invert page only and it would be impossible to not invert images. |
It didn't work for me either a few days ago, but then a couple of days later it started working again (maybe the upgrade to Chrome 66 fixed that somehow). Anyhow, now I saw the new Dynamic mode, and pdfs aren't inverted by it, nor by static (but they do by both Filter and Filter+). Thanks for everything! |
^ - yup same experience here |
It does not work on firefox. I am using the last version of ff. |
The darkification of PDF files works when using Filter+ (not with Dynamic). My usual solution is saving the config with Filter+ only for the current webpage, but it's annoying doing that with every site that have a PDF. I suggest to apply Filter+ (if it isn't the default engine) to all PDFs. EDIT: I forgot to say this is using Chrome 71.0.3578.98 with Dark Reader 4.7.5 |
@Raijin56 What si |
@eromoe they are talking about this It seems to work on Chromium, Google Chrome but not on Firefox, nor Waterfox. |
@rolagg Not possible to make local PDFs dark? My eye strains reading books on computer. |
@sbelharbi Hey, thanks for the reply. I mean chrome's built-in PDF reader. I don't have any apps installed. I just drag a PDF to chrome. I wish the extension could make it dark too. For now, the workaround is to upload the PDF to google drive and read it from there with dark reader extension. |
I see.
|
I want to have as few apps as possible. Also an old system. |
going through Google drive is a solution, than. |
Agreed with Raijin56. I suggest automatically applying Filter+ to all PDFs. Also, it seems that DarkReader can only accept the site-wise configuration. It would be much more helpful if we could use more customed pattern matching and I don't think there would be any difficulty to implement this feature. |
This is not working anymore. Pity. :( |
@luo-chuan you need use |
I used the Filter+ mode, it works on the online pdf file, but not at the local pdf file. |
Filter+ Causes the Sidebar to become white. |
Black Sidebars would be GREAT! Maybe this turns out to become a 'PDF Mode' Filter+ isn't perfect for the job yet. (Better than nothing though) |
How can I configure the Dark Reader Google Chrome extension so that the Filter+ mode is only activated for PDFs? For the other webpages I want to keep the dynamic mode. Also, how can I change the grey background of the PDF preview in Google Chrome to black? |
Hey, I've had this problem of local PDFs not becoming dark. I switched to Filter+, and it worked on my desktop, but not on my laptop. I ensured they're both the same version (4.9.5). Any idea why it wouldn't work on my laptop? Maybe your new change would fix it? Has it made it to a release yet? |
@Gusted @alexanderby Got time to answer my questions above? |
We didn't touched PDF make sure you have permission for file:// enabled |
Correct, that was the issue. Thank you! |
Where is the option? |
https://darkreader.org/help/en/#faq ->
|
I can't find the enablePDF option for any pdf files. |
It isn't an option yet, it will be an option with darkreader V5 Open a seperate issue for your question |
Can I just clone the repo and build v5 for myself? |
Buggy and not fast ATM |
Ok, I'll wait then. Thanks! |
Now it is working in Chrome Browser, but I can not turn it off :( |
|
for local pdf in firefox adjust the numbers according to your preference. |
You can even run this with one click by creating a new bookmarklet (bookmark) with the following Location (target): Instructions: create a bookmark in Firefox by pressing CTRL+B > right-click the target folder, e.g. "Bookmarks Menu" > "New Bookmark ...". |
it seems to be working fine on file PDF #374 (comment) but how to set dark reader to not invert toolbar and sides? |
I find from a reddit thread that you could input
in the browser console to invert the page without affecting the toolbar and the background. |
@Gravifer I disabled dark mode, opened the console, and pasted your code to it. |
@jirikrepl sorry I didn't clarify the context; I am using Microsoft Edge, and the team modified the viewer plugin. The command actually only inverts the content when the controls are in night mode. Maybe we should hack the plugin already... This is silly. |
Thanks! This worked smoothly!! |
As per users, PDF are opening in darkmode if accessed on webpage residing on webserver. Why we can't have a local webserver running and read file from it. I've done exactly that and it works. No extra addins. A few mins of work and you have it.
// Header content type // Read the file
|
Despite the PR being merged, I am failing to get dark PDFs in Firefox: Edit: I noticed there is a discussion about doqment as a replacement for the default firefox PDF reader with a basic inversion capability. |
If you use Firefox, you can edit userContent.css like this: @media (prefers-color-scheme: dark){
.pdfViewer{filter: invert(1) hue-rotate(180deg);}
} If you use Chrome or Edge, install the extention "PDF Reader", then edit the extention option like this: html[data-theme*="dark"] .pdfViewer{
filter: invert(1) hue-rotate(180deg);
} |
According to some review and my experience on Chrome.
The text was updated successfully, but these errors were encountered: