Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] I can not login into my local phpmyadmin when both darkreader and keepassxc are enabled in firefox #4763

Open
nonamereq opened this issue Jan 13, 2021 · 14 comments
Labels

Comments

@nonamereq
Copy link

Describe the bug

I can't login into phpmyadmin when both dark reader and keepassxc are enabled in about:addons in Firefox. The error message says failed to set session cookie.

Steps to reproduce

  • Only enable Dark reader and keepassxc-browser addons in firefox
  • Go to your phpmyadmin page and try to login

Expected behavior

You login to phpmyadmin.

Actual behavior

Phpmyadmin shows an error.

Screenshots

image

System Information:

  • OS: Arch Linux
  • Browser: Firefox 84.0.2
  • Dark Reader version: 4.9.26

Additional context

I use keepassxc-browser addon with dark reader.

@nonamereq nonamereq added the bug label Jan 13, 2021
@Gusted
Copy link
Contributor

Gusted commented Jan 13, 2021

Hi @nonamereq!

Does this work when you have Dark Reader disabled?

Regards,
Gusted

@nonamereq
Copy link
Author

Yes it works. It doesn't work when both are enabled. When one is disabled it works.

@Gusted
Copy link
Contributor

Gusted commented Jan 13, 2021

Yes it works. It doesn't work when both are enabled. When one is disabled it works.

So if e.g. Keepassxc is enabled and Dark Reader is disabled it doesn't raise an error and visa-versa?
I'm trying to understand how this can happen as this doesn't add up for me.

@nonamereq
Copy link
Author

So if e.g. Keepassxc is enabled and Dark Reader is disabled it doesn't raise an error and visa-versa?

Yes that's right

@Gusted
Copy link
Contributor

Gusted commented Jan 13, 2021

Hmm okay, does it show any errors in the console?

@nonamereq
Copy link
Author

If I enable both
2021-01-13-225316_1918x1059_scrot

If I disable dark reader
2021-01-13-225359_1918x1059_scrot

@nonamereq
Copy link
Author

All I see as far as errors go is some cookies being rejected. And that is in both cases

@nonamereq
Copy link
Author

nonamereq commented Jan 13, 2021

I found this question, and if i set phpmyadmin auth_type to http i can login in but not in cookie mode

@Gusted
Copy link
Contributor

Gusted commented Jan 13, 2021

I'm unsure why Dark Reader is causing to Keepassxc(Due to cookies that we don't modify neither have access to and filling the input field) to let this error happen, I think you will have more success solving this issue over at https://github.com/keepassxreboot/keepassxc-browser/issues

@Optimus1008
Copy link

Got the same error, and it drove me nuts, but I finally found out that Dark Reader is causing this!
Tested it on a few different machines and different browsers, and it's safe to say that it's caused solely by Dark Reader…
The workaround is thankfully pretty easy: just disable the filter (i.e. with a shortcut), login and enable again!
I also found out that it's only caused by the dynamic style generator; the others (static, filter(+)) don't cause the issue.
I'm not nearly enough knowledgeable to dig into this any deeper, but I hope I either helped to get this fixed or helped someone like me to find a workaround. :-)

@dverbru
Copy link

dverbru commented Jan 8, 2023

@nonamereq although you found a workaround, the bug is still there, and affect other sites which we have no control over. For example, it is not possible to log in to westernunion.com. Can you please reopen it?

@Gusted since I installed Dark Reader yesterday, I found two websites I can't log into. Also on Firefox and using KeepassXC. Never had such problem before on those sites (accessed them regularly for years). I think this deserves some investigation, since it gives quite a bad taste regarding security. Thank you!

@nonamereq nonamereq reopened this Jan 17, 2023
@nonamereq
Copy link
Author

I have removed this plugin that's why i closed the issue. @dverbru I think it is better if you open a new issue

1 similar comment
@nonamereq

This comment was marked as duplicate.

@Gusted
Copy link
Contributor

Gusted commented Feb 9, 2023

@Gusted since I installed Dark Reader yesterday, I found two websites I can't log into. Also on Firefox and using KeepassXC. Never had such problem before on those sites (accessed them regularly for years). I think this deserves some investigation, since it gives quite a bad taste regarding security. Thank you!

I'm not an KeepassXC developer, I cannot make a guess how and why dark reader is interfering with them. Nor have I a local reproducer to report this to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants