[BUG] The site-toggle button randomly stops working on certain sites.

[bonecountysheriff]

Bug Report

Describe the bug

Darkreader sometimes automatically disables itself for certain sites which were working previously. It reads "Disabled for current website". Pressing the site-toggle button does nothing. I'm not sure if it's just me.

Basically, $('.site-toggle').click() does nothing.

Right now, I'm seeing this behavior https://codeforces.com in the brave browser.

Steps to reproduce

• Start brave browser
• Go to codeforces.com
• Try enabling darkreader using the site-specific (not global) button

-- or --

chrome.runtime.connect({name: 'ui'}).postMessage({type: "toggle-url", data: "https://codeforces.com"})

Run this on darkreader's console.

Expected behavior

Dark mode

Actual behavior

Dark mode disabled, cannot enable. Pressing the site-toggle button doesn't toggle it.

Screenshots

System Information

• OS: linux
• Browser: brave
• Dark Reader Version: 4.9.32

Additional context

[bonecountysheriff]

chrome.runtime.connect({name: 'ui'}).postMessage({type: "toggle-url", data: "https://codeforces.com"})

Running this on darkreader's console does nothing.

[ghost]

Not reproducible on firefox, can't bother to download brave because chromium browsers tend to crash 99.999% of the time 😔

[Gusted]

I don't really see anything why this shouldn't other then that you already have a entry in your sitelist that is conflicting with this site.

[bonecountysheriff]

Even if the entry was present, wouldn't it be removed when the button is toggled?
In my case, the button doesn't change state at all.

One more thing. If enabled by default(in the settings menu) is disabled, the site starts to obey darkreader. This time the site-toggle button stays enabled instead of disabled. And like before, pressing the site-toggle neither changes the state of the button, nor the site.

So I'm guessing the problem is with the button itself and not a css glitch.

[Gusted]

Even if the entry was present, wouldn't it be removed when the button is toggled?

Not really, it might be conflicting but it won't be removed when the button it's toggled.

Could you send over the sites you have in your list? Or see if you think anyone of them is causing this problem as it could be matching the same domain.

[bonecountysheriff]

Apparently putting <prefix> in the sitelist causes this behavior for <prefix>*. I think this should be a bug, but I'm not sure if the maintainers would agree. Anyways, problem seems to be solved.

[Gusted]

#147

[Francewhoa]

If you're facing this challenge on a subdomain, it is likely a bug

This is to confirm this bug on subdomaines with Dark Reader V4.9.62. Using Firefox V102.7 or Ungoogle Chromium V109.0.

For users facing this challenge on subdomains, I published this easy, quick, and temporary workaround.

For developers interested to contribute to resolving this bug, you might be interested in this:

• Steps to reproduce
• Pull request at Better URL Matching #2517