Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added albanesi.dev, nezia.dev, and stirnemann.xyz #10657

Closed
wants to merge 1 commit into from
Closed

Added albanesi.dev, nezia.dev, and stirnemann.xyz #10657

wants to merge 1 commit into from

Conversation

suguuss
Copy link

@suguuss suguuss commented Jan 19, 2023

No description provided.

@bershanskiy bershanskiy mentioned this pull request Jan 21, 2023
Open
@bershanskiy
Copy link
Contributor

Hi @suguuss, do you happen to own albanesi.dev? if so, could you please just signal to Dark Reader that you would like it to disable itself by adding the following to your page?

<head>
  <meta name="darkreader-lock"></meta>
</head>

@bershanskiy
Copy link
Contributor

I simulated addition of this tag via the following script run in the console and the site seemed to work:

const m = document.createElement('meta');
m.name = 'darkreader-lock';
document.head.appendChild(m);

@suguuss
Copy link
Author

suguuss commented Jan 22, 2023

@bershanskiy I added the meta tag to my website (albanesi.dev), do I also need to add it to nezia.dev and stirnemann.xyz ?

@bershanskiy
Copy link
Contributor

@suguuss Thanks for adding the HTML lock to albanesi.dev, it works.

Yes, to make Dark Reader disable itself on nezia.dev and stirnemann.xyz those sites also should add this code. If you do not have control over these sites, I can add them to disabled list. However, it is typically better for the site to add the lock because this allows the site to configure behavior of Dark Reader by itself, without waiting for Dark Reader update (which is subject to Dark Reader development timelines and Chrome Web Store and Firefox Addons Store review timelines).

@suguuss
Copy link
Author

suguuss commented Jan 22, 2023

@bershanskiy Thanks for the informations ! I can add the tags to those sites. I will close the pull request now.

@suguuss suguuss closed this Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suguuss @bershanskiy