Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for pcgamer.com #12613

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Fixes for pcgamer.com #12613

merged 2 commits into from
Apr 19, 2024

Conversation

hazzuk
Copy link
Contributor

@hazzuk hazzuk commented Apr 19, 2024

Fixed text readability by reverting to default colours, and fixed site logo by adding path (element used in the sites svg logo) to ignore inline styling.

Before:

pcgamer-before

After:

pcgamer-after

Fixed text readability by reverting to default colours, and fixed site logo by adding it to ignore inline styling.
@hazzuk
Copy link
Contributor Author

hazzuk commented Apr 19, 2024

Related issues #12480, #12507.

@alexanderby
Copy link
Member

Thank you for the fix. But I will try figuring out what's wrong with CSS layers again.

alexanderby added a commit that referenced this pull request Apr 19, 2024
@alexanderby
Copy link
Member

My fix seems to be working for colors, but not the logo. Could you please remove the fix for the links, but leave the fix for the SVG logo?

@hazzuk
Copy link
Contributor Author

hazzuk commented Apr 19, 2024

@alexanderby done, thank you for the fix 👍

@alexanderby alexanderby merged commit 2c9d37e into darkreader:main Apr 19, 2024
1 check passed
@alexanderby
Copy link
Member

Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants