This repository has been archived by the owner on Apr 25, 2020. It is now read-only.
Changing Forecast::IO to ForecastIO to avoid naming collisions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase and squash so I can automatically merge the pull request? Thanks. |
This avoids namespacing issues with other projects (e.g. Rails apps) with classes called Forecast. Forgot the IO suffix in version file. Merge fix. Updating new docs with new namespace.
|
Done. |
czarneckid
added a commit
that referenced
this pull request
Jul 5, 2013
Changing Forecast::IO to ForecastIO to avoid naming collisions
|
@pat Thanks again for the pull request. Release 2.0.0 earlier today, https://twitter.com/CzarneckiD/status/353177951921111040 |
|
Thanks David, really appreciate both the quick merge and quick 2.0 release :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in an earlier comment, here's the pull request with the namespacing change.
Generally I feel gems should have namespaces matching their names, and make a reasonable attempt to avoid collisions with commonly named objects in others' code. Granted, this change will require a serious bump to the version number - probably to 2.0.
If you don't want to merge this in, keen to hear reasons why :)