Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: increased LUT3D flexibility #12261

Closed
kmilos opened this issue Aug 1, 2022 · 7 comments · Fixed by #14942
Closed

Feature request: increased LUT3D flexibility #12261

kmilos opened this issue Aug 1, 2022 · 7 comments · Fixed by #14942

Comments

@kmilos
Copy link
Contributor

kmilos commented Aug 1, 2022

This is coming out of discussion in #10709 and #12260

The improved LUT3D module should:

  • not assume input LUT profile = output LUT profile (i.e. separate the single LUT "application" profile to an input one and and output one); there are numerous LUTs that transfer from a wide gamut, log encoded space to a narrower/display one using some creative style...
  • support input & output LUT profiles from ICC files (from user or system supplied color/in and/or color/out) and also use the existing built-in (working?) profile list, potentially deprecating the currently fixed and limited list (i.e. behave similar to working profiles list of the colorin module)
  • optionally expose intent control for the working->lut_input and lut_output->working profile transforms
@aurelienpierre
Copy link
Member

not assume input LUT profile = output LUT profile (i.e. separate the single LUT "application" profile to an input one and and output one); there are numerous LUTs that transfer from a wide gamut, log encoded space to a narrower/display one using some creative style...

That makes no sense. Or, by "profile", you actually mean "color space" ? In any case, having LUTs do the color space conversion removes any color traceability and voids the guaranty. Moreover, those log-encoded RGB belong only to cinema.

support input & output LUT profiles from ICC files (from user or system supplied color/in and/or color/out) and also use the existing built-in (working?) profile list, potentially deprecating the currently fixed and limited list (i.e. behave similar to working profiles list of the colorin module)

What problem is that supposed to solve ? Supporting stuff for the sake of supporting stuff is nonsensical, especially since ICC profiles are already supported where they should.

This FR sounds like someone woke up with grand ideas regarding features but no actual use case.

@phweyland
Copy link
Contributor

LUT3D could be used for other use cases than color grading.
There is some room between raw data and colorin which fits with the limit [0,1] domain and would require to have different input and output color spaces. For lack of LOG raw image I've never checked this case.

@github-actions
Copy link

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@parafin
Copy link
Member

parafin commented Apr 13, 2023

I hit this limitation just now, specifically I want to use a LUT with ProPhoto linear RGB input and output colorspace and it is missing from the list. Could we at least extend the list with all built-in colorspaces we have? ProPhoto linear RGB is available in colorin iop as a working profile.

@kmilos
Copy link
Contributor Author

kmilos commented Apr 13, 2023

@parafin I wasn't really planning on working more on #12265, so please feel free to take it over.

@parafin
Copy link
Member

parafin commented Apr 13, 2023

If there's noone working on this, I might add ProPhoto to the list, but I doubt I'll have enough motivation to tackle other points.

@github-actions
Copy link

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants