New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.2.1 crashes when importing and building thumbnails for negadoctor-processed pictures #14325
Comments
As already mentioned on pixls this is related to a bug in the denoiser, that has been fixed already on master, so for 4.4 In the meantime, you should use another module that does the denoising for you :-) |
@jenshannoschwalm he said that he tested master too. |
Sorry, missed that. Nevertheless i couldn't reproduce here. @redmoon1945 two questions
|
Hi, as a matter of fact, master 4.3.0 produces the same problem. But 4.0.0 flatpak works fine (just tried it on Kubuntu 23.04). |
It took some effort but I was able to reproduce once on master (4.3.0~git1979.0c3b3fbc). Fedora 37 KDE, Nvidia 3060 12gb Vram. I set the Resources to small and turned off opencl. I've tried again but I cant get it repeat.
|
congrat gl-man ! You got it !! In my case, the resource were set to Large. Yes, not easily reproductable, although with my 2000 negadoctor-processed files (no problem when negadoctor is not involved), it crashes quite rapidly, all the time, but not at the same image. |
My reports means that it looks we still have an issue with nlmeans in the current version of code. Can you rename the issue to something like: segfaults from nlmeans with negadoctor on current master. |
I can get this crash very (very) reliable, so far only without open cl. And it's enough to have Astro Denoise on and Negadoctor can be off. If I can offer any information or testing, I'm happy to copy&paste your commands into my CLI. |
I managed to get to to segfault under gdb (openCL off). This is darktable 4.3.0~git2027.2b3d5ec0
|
@ralfbrown the issue title is misleading, this is again an I tried pretty hard and could not trigger any crashes, do you have an idea on this? Could it be a |
@gi-man Does the code still segfault if you change the two occurrences of |
Something I noticed was i have artefacts while zooming... |
I tested with master first and it took a while to get it to crash. I turned off OpenCL, set resources to small and zoomed in to 400% while playing with exposure. I managed to get it to crash twice. I did the edit you suggested and could not get it to crash. |
Describe the bug
4.2.1 started to crash when I import images all processed with negadoctor, more precisely at thumbnail creation it appears. Running Linux Mint 21.1 (32 GB of RAM). Using flatpak DT 4.2.1 as of 24 apr 2023, but same problem with 4.3 master branch darktable_4.3.0~git1954.80bfae38-1+9840.1_amd64.deb.
I tried importing these images from a brand new Linux Kubuntu 23.04, with empty DT database and brand new install of DT 4.2.1 flatpak. The crash occurs the same, but not for the same images set… I tried many times by deleting the data and library db. So lets say I have set A,B,C of photos. If I change the order of importing (one set at a time), the crash does not occur for the same set.
I provide console output for "darktable -d all". Systematically, the last lines are about nlmean.
I have been able to reproduce the problem with only 4 files, that can be found here :
https://drive.proton.me/urls/J43P4NC69W#XYma9ZxaheyR
It is random, so I had to play for 10 minutes doing this
→ erase library.db, data.db
→ darktable -d all
→ loop
>load one or many of these 4 images
-> always switch to Lighttable
-> while loading , resizing thumbnail size (the crash still occur if I dont do that)
-> remove all of them (without deleting the files)
→ rinse and repeat until segmentation fault. Takes usually 5 to 10 minutes)
All files causing the problem have been processed with negadoctor.
Note :
Steps to reproduce
→ erase library.db, data.db
→ darktable -d all
→ loop
>load one or many of these 4 images
-> always switch to Lighttable
-> while loading , resizing thumbnail size (the crash still occur if I dont do that)
-> remove all of them (without deleting the files)
→ rinse and repeat until segmentation fault. Takes usually 5 to 10 minutes)
Expected behavior
DT should not crash
Logfile | Screenshot | Screencast
output of darktable -d all, look at the end to see the potential culprit (nlmean)
Commit
?
Where did you install darktable from?
flatpak
darktable version
4.2.1
What OS are you using?
Linux
What is the version of your OS?
Mint 21.1, with all the latest patches and updates
Describe your system?
System:
Kernel: 5.15.0-70-generic x86_64 bits: 64 compiler: gcc v: 11.3.0
parameters: BOOT_IMAGE=/vmlinuz-5.15.0-70-generic
root=/dev/mapper/vgmint-root ro quiet splash
Desktop: Cinnamon 5.6.8 tk: GTK 3.24.33 wm: muffin vt: 7
dm: LightDM 1.30.0 Distro: Linux Mint 21.1 Vera base: Ubuntu 22.04 jammy
Machine:
Type: Laptop System: LENOVO product: 21CQ000GUS v: ThinkPad T14s Gen 3
serial: Chassis: type: 10 serial:
Mobo: LENOVO model: 21CQ000GUS v: SDK0T76530 WIN
serial: UEFI: LENOVO v: R22ET61W (1.31 )
date: 03/21/2023
Battery:
ID-1: BAT0 charge: 50.6 Wh (89.6%) condition: 56.5/57.0 Wh (99.1%)
volts: 16.6 min: 15.4 model: Sunwoda LNV-5B10W51876�� type: Li-poly
serial: status: Not charging cycles: 37
CPU:
Info: model: AMD Ryzen 7 PRO 6850U with Radeon Graphics bits: 64
type: MT MCP arch: Zen 3 family: 0x19 (25) model-id: 0x44 (68) stepping: 1
microcode: 0xA404102
Topology: cpus: 1x cores: 8 tpc: 2 threads: 16 smt: enabled cache:
L1: 512 KiB desc: d-8x32 KiB; i-8x32 KiB L2: 4 MiB desc: 8x512 KiB
L3: 16 MiB desc: 1x16 MiB
Speed (MHz): avg: 1404 high: 1555 min/max: 1600/4767 boost: enabled
scaling: driver: acpi-cpufreq governor: schedutil cores: 1: 1396 2: 1397
3: 1471 4: 1456 5: 1365 6: 1389 7: 1375 8: 1365 9: 1555 10: 1379 11: 1397
12: 1396 13: 1396 14: 1397 15: 1362 16: 1372 bogomips: 86230
Flags: avx avx2 ht lm nx pae sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3 svm
Vulnerabilities:
Type: itlb_multihit status: Not affected
Type: l1tf status: Not affected
Type: mds status: Not affected
Type: meltdown status: Not affected
Type: mmio_stale_data status: Not affected
Type: retbleed status: Not affected
Type: spec_store_bypass
mitigation: Speculative Store Bypass disabled via prctl and seccomp
Type: spectre_v1
mitigation: usercopy/swapgs barriers and __user pointer sanitization
Type: spectre_v2 mitigation: Retpolines, IBPB: conditional, IBRS_FW,
STIBP: always-on, RSB filling, PBRSB-eIBRS: Not affected
Type: srbds status: Not affected
Type: tsx_async_abort status: Not affected
Graphics:
Device-1: AMD Rembrandt vendor: Lenovo driver: amdgpu v: kernel pcie:
gen: 4 speed: 16 GT/s lanes: 16 ports: active: DP-2,eDP-1
empty: DP-1, DP-3, DP-4, DP-5, DP-6, HDMI-A-1 bus-ID: 33:00.0
chip-ID: 1002:1681 class-ID: 0300
Device-2: Acer Integrated Camera type: USB driver: uvcvideo bus-ID: 5-1:2
chip-ID: 5986:1177 class-ID: fe01 serial:
Display: x11 server: X.Org v: 1.21.1.4 driver: X: loaded: amdgpu,ati
unloaded: fbdev,modesetting,vesa gpu: amdgpu display-ID: :0 screens: 1
Screen-1: 0 s-res: 4096x4224 s-dpi: 120 s-size: 867x894mm (34.1x35.2")
s-diag: 1245mm (49")
Monitor-1: DisplayPort-1 mapped: DP-2 pos: primary,top-left
model: Dell S2719DC serial: built: 2020 res: 4096x2304 hz: 60
dpi: 174 gamma: 1.2 size: 597x336mm (23.5x13.2") diag: 685mm (27")
ratio: 16:9 modes: max: 2560x1440 min: 720x400
Monitor-2: eDP pos: primary,bottom-r res: 3072x1920 hz: 60 dpi: 258
size: 302x189mm (11.9x7.4") diag: 356mm (14")
OpenGL:
renderer: REMBRANDT (rembrandt LLVM 15.0.6 DRM 3.42 5.15.0-70-generic)
v: 4.6 Mesa 22.2.5 direct render: Yes
Audio:
Device-1: AMD vendor: Lenovo driver: snd_hda_intel v: kernel pcie: gen: 4
speed: 16 GT/s lanes: 16 bus-ID: 33:00.1 chip-ID: 1002:1640 class-ID: 0403
Device-2: AMD Raven/Raven2/FireFlight/Renoir Audio Processor
vendor: Lenovo driver: snd_pci_acp6x v: kernel
alternate: snd_pci_acp3x,snd_rn_pci_acp3x,snd_pci_acp5x pcie: gen: 4
speed: 16 GT/s lanes: 16 bus-ID: 33:00.5 chip-ID: 1022:15e2
class-ID: 0480
Device-3: AMD Family 17h HD Audio vendor: Lenovo driver: snd_hda_intel
v: kernel pcie: gen: 4 speed: 16 GT/s lanes: 16 bus-ID: 33:00.6
chip-ID: 1022:15e3 class-ID: 0403
Sound Server-1: ALSA v: k5.15.0-70-generic running: yes
Sound Server-2: PulseAudio v: 15.99.1 running: yes
Sound Server-3: PipeWire v: 0.3.48 running: yes
Network:
Device-1: Qualcomm Atheros QCNFA765 vendor: Lenovo driver: ath11k_pci
v: kernel pcie: gen: 2 speed: 5 GT/s lanes: 1 link-max: gen: 3
speed: 8 GT/s port: N/A bus-ID: 01:00.0 chip-ID: 17cb:1103 class-ID: 0280
IF: wlp1s0 state: down mac:
Device-2: Lenovo Thinkpad LAN type: USB driver: r8152 bus-ID: 10-1.1:3
chip-ID: 17ef:7205 class-ID: 0000 serial:
IF: enx3c18a01e39cf state: up speed: 1000 Mbps duplex: full mac:
IF-ID-1: ipv6leakintrf0 state: unknown speed: N/A duplex: N/A
mac:
IF-ID-2: proton0 state: unknown speed: 10 Mbps duplex: full mac: N/A
Are you using OpenCL GPU in darktable?
No
If yes, what is the GPU card and driver?
No response
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
It was working with 3.8.1 for sure. I think it was also working with 4.2.1 some time ago (cannot confirm that)
The text was updated successfully, but these errors were encountered: