Selection is not working correctly in filmstrip

[robyquin]

Describe the bug

Selection is not working correctly in filmstrip (darkroom).

In stripfilm I select multiple images (shift + left button), then I leave and select only one, the previous images remain selected.

The same thing happens if I come from multiple images selected in Lighttable and move to Darkroom.

Steps to reproduce

1. in Lighttable I select multiple images (white flowers and butterfly)
2. I switch to Drakroom and in stripfilm I see these selected images
3. Now, in filmstrip, I select another image (red flower)
4. images with white flowers remain selected

Expected behavior

What I would expect from the selection in the filmstrip is to have a behavior similar to what you find on the lighttable.

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you install darktable from?

github.com/darktable-org

darktable version

4.3.0+2188~gf2f04d4834

What OS are you using?

Windows

What is the version of your OS?

Windows 10

Describe your system?

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

[robyquin]

The problem is solved if we comment the code related to DT_THUMBNAIL_SEL_MODE_MOD_ONLY

darktable/src/dtgtk/thumbnail.c

Lines 953 to 954 in a15f636

	if(dt_modifier_is(event->state, 0)
	&& thumb->sel_mode != DT_THUMBNAIL_SEL_MODE_MOD_ONLY)

darktable/src/dtgtk/thumbtable.c

Lines 558 to 562 in a15f636

	if(table->mode == DT_THUMBTABLE_MODE_FILMSTRIP)
	{
	thumb->single_click = TRUE;
	thumb->sel_mode = DT_THUMBNAIL_SEL_MODE_MOD_ONLY;
	}

darktable/src/dtgtk/thumbtable.c

Lines 615 to 619 in a15f636

	if(table->mode == DT_THUMBTABLE_MODE_FILMSTRIP)
	{
	thumb->single_click = TRUE;
	thumb->sel_mode = DT_THUMBNAIL_SEL_MODE_MOD_ONLY;
	}

darktable/src/dtgtk/thumbtable.c

Lines 2241 to 2245 in a15f636

	if(table->mode == DT_THUMBTABLE_MODE_FILMSTRIP)
	{
	thumb->single_click = TRUE;
	thumb->sel_mode = DT_THUMBNAIL_SEL_MODE_MOD_ONLY;
	}

darktable/src/dtgtk/thumbtable.c

Lines 2373 to 2377 in a15f636

	if(mode == DT_THUMBTABLE_MODE_FILMSTRIP)
	{
	sel_mode = DT_THUMBNAIL_SEL_MODE_MOD_ONLY;
	single_click = TRUE;
	}

[AlicVB]

If I understand correctly, what you see is here by design :

• We try very hard to avoid unwanted drop of the selection while working with filmstrip (darkroom or culling)
• In filmstrip, single click change the active image, so we can't use that for changing selection too.

That's why you need to use modifier keys to change selection in filmstrip (ctrl or shift)

[robyquin]

If I understand correctly, what you see is here by design :

* We try very hard to avoid unwanted drop of the selection while working with filmstrip (darkroom or culling)

* In filmstrip, single click change the active image, so we can't use that for changing selection too.

That's why you need to use modifier keys to change selection in filmstrip (ctrl or shift)

OK! Now it’s clearer!

But while I agree with this choice, on the other hand I consider it dangerous to keep the selection coming from another environment (like Lighttable)

In filmstrip we do not have the complete view of the selection, so in lighttable I get help from the filters of the collection, going to darkroom/map, I would like to have no selection and then select images of interest

[robyquin]

I would like to be clearer, I think there are areas of ambiguity (???).
User side the theme of the selection looks like this:

[Nilvus]

There's no ambiguity @robyquin. Just a design choice (I do not agree with this choice). Unfortunately, this do not really move and had been discussed a lot. Maybe one time darktable will have a way to select like all other software on that part. See related issue here: #6025

As 4.4 will be feature freeze in just few days, this will not change for next release. But could be a good Christmas if this change on 4.6.

Your issue is so a duplicate of #6025. So I suggest you to close this one and continue discussion on #6025.