-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS Sonoma Build Bugs #15201
Comments
libomp is mentioned in https://github.com/darktable-org/darktable/blob/master/packaging/macosx/BUILD-ARM64.txt |
That would explain it, opened the wrong file on the build instructions. Wondered what changed so much between now and my Ventura VM. Need to upgrade my Intel machine to Sonoma later and see if those work. |
Ran into an issue building cargo-c (a dependency for libgphoto2) in MacPorts, more of an upstream issue than a darktable one. Even if I let it download a pre-built binary instead of building from source, it's no go, will try to report it to MacPorts.
|
Since github runner builds are based on Homebrew it would be interesting to see how that goes on Sonoma. |
Hm, pretty sure ligphoto2 has no Rust code, so it's probably a dependency of something else... |
That's what I thought too but MacPorts computes it as a prerequisite, it might be a dependency of a dependency or something too. libgphoto2 has several dependencies. |
That's what I meant. It's definitely not a direct dependency of libgphoto2. Most likely ligphoto2->gd2->libavif/libheif->rav1e 🙄 So you could also try building w/ |
I can do that, are the release binaries still built against MacPorts as Homebrew doesn't allow building against previous releases? |
The release binaries for x86_64 are built with Homebrew for macos-11 or higher. |
Homebrew steps work to build the bundle, only catch was I had to manually specify However the resulting app package fails to launch with:
|
And the resulting binary cannot run on Ventura at all. |
Did you run the |
Yes. |
Please post the output of
|
|
Ok, Homebrew on M1 systems is installed in a different base directory than on x86_64 systems. Can you please redirect the output of |
hmm, the What gives
|
Your log is full of messages like this:
which seems to be a macOS arm64 specific issue |
Yup, I noticed that. It's been a while but I do recall building it successfully in a Ventura VM on ARM with homebrew a few months back (since then I went to the MacPorts method). Has something changed in Sonoma. |
Output from that shows nothing:
|
|
so I did, sorry bouncing between work and this at the moment:
|
That looks ok and should be handled by the package building script accordingly. |
That’s the reason to use macports when you need to set a deployment target older than the os on your build machine… |
@leanderhutton: Can you please edit
The script should then look as follows at that position:
Then re-run the script |
Yeah, that's why I was using MacPorts the first go around. I thought the Homebrew builds were for nightlies only?
Doing that now, that block shows up at line 102 in the repo, but got it in there. Thanks. |
New crash report from fresh .app package after script modifications:
|
this is what that whole block of the script looks like after modification, lines 91-109:
|
Are the warnings still in the log?
|
Some people use Macports, others use Homebrew as their package manager. |
Yes, please see attached. |
Ok, changing the libraries signatures does not help here. Please reset the script to its original state. For some reason, the packaging script The script does not make any modifications, it just prints some results on how the libraries in the darktable package are handled during the packaging process. For that, it only uses
|
Updated the LIB path for Apple Silicon:
Output:
|
Yes, I was just surprised that a switch had been made to HB for the official builds given the backwards compatibility issues for older releases of MacOS. I'm thankful to have both as Homebrew ran over my dog while his buddy pointed and laughed so I prefer MacPorts myself. Also more familiar with ports from my FreeBSD days. |
The output of So can you please edit line 88: line 113: line 120: line 138: The re-run |
Sorry for the delay @zisoft but I finally got a chance to try this today. I was building the release-4.4.2 branch so that's why my line numbers weren't lining up, switched to master. Nonetheless, this worked I now have a working darktable app package in Sonoma. |
Great to hear that, thank you! |
Still no luck with the MacPorts build but that's more to do with problems with MacPorts than darktable. I'll keep checking with the MacPorts project for that. |
If this is still a problem please file a ticket at macports |
macports released a sonoma package several days ago, so there are no longer issues expected - at least all darktable dependencies were built fine for m1 last week… |
Describe the bug
I'm doing some test builds on a macOS Sonoma VM and have found some issues with the process. Documenting them here, potentially fixing some. I compiled Mac Ports from source as there is no Sonoma package available yet. This is a clean install of Sonoma Beta 8 for the sole purpose of testing darktable building. Figured it's a good time to get out in front of this and test it out before Sonoma proper is released.
Steps to reproduce
CMake Error at /opt/local/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES) (Required is at least version "4.5") Call Stack (most recent call first): /opt/local/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE) /opt/local/share/cmake-3.24/Modules/FindOpenMP.cmake:545 (find_package_handle_standard_args) CMakeLists.txt:90 (find_package)
This was fixed with
port install libomp
so I think that should probably be added to the package list in the documentation maybe?Second error I cannot get past is:
I've got Xcode beta 15 installed and the command line tools beta, clang reports the following:
Expected behavior
produce dmg file and .app package
Where did you install darktable from?
self compiled
darktable version
4.4.2
What OS are you using?
Mac
What is the version of your OS?
macOS 14 Sonoma
Describe your system?
VM on M2 Max
Are you using OpenCL GPU in darktable?
Yes
If yes, what is the GPU card and driver?
M2 Max
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
No response
The text was updated successfully, but these errors were encountered: