Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tone equalizer: displayed exposure mask affected by iops coming later in the pipeline #3211

Closed
flannelhead opened this issue Oct 25, 2019 · 4 comments

Comments

@flannelhead
Copy link
Contributor

Describe the bug
When tone equalizer is enabled and "display exposure mask" is on, iops coming later in the pipeline affect the displayed exposure mask.

To Reproduce
Steps to reproduce the behavior:

  1. Enable e.g. Filmic RGB with some added contrast
  2. Enable tone equalizer and click "display exposure mask"
  3. Ensure tone equalizer comes before Filmic RGB in the pipeline
  4. Disable and enable Filmic RGB and observe that the displayed exposure mask changes. Note that the displayed histogram on tone equalizer's "advanced" tab fortunately doesn't change, nor do the values displayed under the cursor when hovering the mask.

Expected behavior
The displayed exposure mask should not change due when enabling or disabling Filmic RGB (or any other module coming later in the pipeline). The dependency on later modules makes it hard to assess the effect of the tone equalizer masking settings.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform (please complete the following information):

  • OS: Arch Linux x86_64
  • Version be6a924

Additional context
@aurelienpierre: what's your suggested workflow with filmic and tone equalizer like? Do you first tune tone equalizer and only then enable filmic rgb and any other iops later in the pipeline? This kind of workflow would work around this problem, but I would still appreciate if I could revisit tuning the tone equalizer mask later without disabling the other modules. I think I'll spend some quality time watching your awesome tutorial videos this weekend anyway :)

@aurelienpierre
Copy link
Member

aurelienpierre commented Oct 25, 2019

The displayed exposure mask should not change due when enabling or disabling Filmic RGB (or any other module coming later in the pipeline). The dependency on later modules makes it hard to assess the effect of the tone equalizer masking settings.

Given how the current pipeline is wired, I'm afraid I have no other option. Either I use the image output, with later modules applied on, or the mask preview, possibly interfering with parametric/drawn blending elsewhere. Notice it's the same issue with the retouch module.

what's your suggested workflow with filmic and tone equalizer like? Do you first tune tone equalizer and only then enable filmic rgb and any other iops later in the pipeline? This kind of workflow would work around this problem,

https://www.youtube.com/watch?v=UuB9khJIrDI

@flannelhead
Copy link
Contributor Author

I suppose this issue may be closed unless someone else thinks the behaviour should be changed. Personally I'm fine with the current behaviour and will adjust the mask before applying any modules further along the pipeline. :)

@TurboGit
Copy link
Member

TurboGit commented Nov 5, 2019

Ok, closing.

@TurboGit TurboGit closed this as completed Nov 5, 2019
@TurboGit
Copy link
Member

TurboGit commented Nov 5, 2019

Ok, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants