Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0.0, lighttable 'max size' image export off by 1 pixel #4412

Closed
DaveBlack opened this issue Mar 2, 2020 · 5 comments
Closed

Version 3.0.0, lighttable 'max size' image export off by 1 pixel #4412

DaveBlack opened this issue Mar 2, 2020 · 5 comments

Comments

@DaveBlack
Copy link

Describe the bug
lighttable 'max size' image export off by 1 pixel

To Reproduce

  1. Open a high resolution image
  2. Using lighttable 'max size' field (either), enter a setting such as 1000
  3. Click 'export' button
  4. Exported image is 999 pixels

Expected behavior
Following above steps, exported image should be 1000 pixels

Platform (please complete the following information):

  • Darktable Version: 3.0.0 (flatpack)
  • OS: Linux Mint 19.3 Cinnamon

Additional context

  • Darktable Version: 2.6.x 'max size' works as expected
  • Jpeg tested
  • Fresh image import, no previous image history
  • Flatpak version used
  • Issue is still present using an empty/new config-dir

Padding
Also (maybe OS related), adding extra padding between text, entry fields, and buttons may help improve readability? Can be opened as separate issue if preferred.

Before
1 padding before

After (GIMP mock-up)
2 padding after (GIMP mock-up)

In closing...
Thank you developers for your time, and all your hard work.

@DaveBlack DaveBlack changed the title Version 3.0.0 lighttable 'max size' image export off by 1 pixel Version 3.0.0, lighttable 'max size' image export off by 1 pixel Mar 2, 2020
@jade-nl
Copy link

jade-nl commented Mar 3, 2020

Duplicate of this issue: #3757

@johnny-bit
Copy link
Member

Which is fixed in 3.0.x and 3.1.0 branches :) so - plz wait for 3.0.1 release which fixes your problem. (except padding in module UI)

@Nilvus
Copy link
Contributor

Nilvus commented Mar 3, 2020

@DaveBlack: as your main issue is a duplicate one and already fixed one (think about searching before posting to help developer community), think about closing this one and create a new one with the padding issue. I indeed never take care of that. When you create this specific padding, think of ping me with my nickname. I will see that.

@Nilvus
Copy link
Contributor

Nilvus commented Mar 3, 2020

@DaveBlack: forget last reply about padding issue. It was simple and quick to fix it so it's done ! See PR mentioned above. Should be in next 3.0.1.

@DaveBlack
Copy link
Author

Thanks all for your replies, and Nilvus for implementing a padding fix.
BTW, carefully read bug report header info. first, performing a preliminary search for lighttable max size, and just max size didn't return helpful results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants