Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please sanity check configuration values on input #6139

Closed
bremner opened this issue Aug 29, 2020 · 3 comments · Fixed by #6403
Closed

Please sanity check configuration values on input #6139

bremner opened this issue Aug 29, 2020 · 3 comments · Fixed by #6403
Labels

Comments

@bremner
Copy link
Member

bremner commented Aug 29, 2020

I recently had a Debian bug report where the user somehow had an empty height setting for the histogram, and was mystified that their histogram didn't work. In order to avoid such problems (and bug reports) it would be nice if obviously nonsensical configuration values could be rejected. One idea that came up on IRC was clamping the numerical values to the ranges specified in the default darktablerc.

@bremner bremner added the feature: enhancement current features to improve label Aug 29, 2020
@johnny-bit
Copy link
Member

It should get min/max from darktableconfig.xml :) default darktablerc only has defaults.

@github-actions
Copy link

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@johnny-bit
Copy link
Member

@bremner - check #6403 should imo cover all your needs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants