Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Huawei P30 Pro #9268

Closed
PeterWem opened this issue Jun 18, 2021 · 6 comments · Fixed by #9423
Closed

Huawei P30 Pro #9268

PeterWem opened this issue Jun 18, 2021 · 6 comments · Fixed by #9423
Assignees
@LebedevRI
Labels
scope: camera support adding WB and raw support for new cameras
Milestone
3.8

Comments

@PeterWem
Copy link
Contributor

Like this post #9223 also Huawei P30 Pro and its colour looks off.
Three cameras, 14 mm, 5 mm and 2 mm. 14 mm camera seems ok but not the 5 mm camera. darktable (exiv2) reports two different focal length for this camera. 6 mm and 5 mm.
Skärmbild från 2021-06-18 14-11-18

CC0 files at https://drive.google.com/file/d/1X95Ta2Jt62o5IM1pDQtHv8FWWpZ8WF2a/view?usp=sharing
@PeterWem PeterWem added the scope: camera support adding WB and raw support for new cameras label Jun 18, 2021
@johnny-bit
Copy link
Member

there's raw for it in raw.pixls.us - https://raw.pixls.us/getfile.php/3060/nice/HUAWEI%20-%20VOG-L29%20-%2016bit%20(4:3).dng ?

@PeterWem
Copy link
Contributor Author

My mistake about the 14 mm camera then. What about the 40 mpix camera? Same name, VOG-L29, but 40 mpix.

@johnny-bit
Copy link
Member

If camera produces more than 1 kind of file, it'd be best to upload all to raw.pixls.us

@PeterWem
Copy link
Contributor Author

Before I wrote here I added the three raw files. 14 mm (already there), 5 mm and 2 mm.

@kmilos
Copy link
Contributor

kmilos commented Jun 18, 2021 •
edited

Does it look any better if you pass it through the Adobe DNG Converter? They list support for this model, wonder if they do anything to the color profile...

One thing to note is that the 40MPix is a RYYB sensor, and what's somewhat strange is there is no difference in ColorMatrix1/2 for the 40MPix RYYB sensor and the 8MPix RGGB one. There is a difference in the ForwardMatrix1/2, but dt doesn't use that method for the input color profile (see Adobe DNG spec for the color science details)...

The 20Mpix sensor has the identical profile to the 8MPix one for both the ColorMatrix1/2 and ForwardMatrix1/2 approaches. Not impossible, but either 1) not 100% right, or 2) Huawei must have paid a pretty penny to have camera module vendors make sure those two sensors have identical color filters, (wildly different) lenses have same spectral transmittance, etc...

Re focal length, it is actually 5.6mm (exiv2 has no problems reading this) - I guess dt decides to round to an integer for the UI only (makes sense for larger, non-mobile sensors). The other 2 are 14.5mm and 2.3mm.

@PeterWem
Copy link
Contributor Author

PeterWem commented Jun 18, 2021 •
edited

Yes, at least the red and a few more patches.
https://drive.google.com/file/d/16wKtRzG5MLBVfWgeLHK8sWBwz44fHBYV/view?usp=sharing

@jenshannoschwalm jenshannoschwalm mentioned this issue Jul 5, 2021
Merged
@johnny-bit johnny-bit added this to the 3.8 milestone Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LebedevRI LebedevRI

Labels
scope: camera support adding WB and raw support for new cameras
Projects
None yet
Milestone
3.8
Development

Successfully merging a pull request may close this issue.

Selecting the best illuminant for dng images jenshannoschwalm/darktable
4 participants
@LebedevRI @kmilos @johnny-bit @PeterWem