Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick access panel → Color calibration description (null) #9308

Closed
ghost opened this issue Jun 22, 2021 · 6 comments · Fixed by #8078
Closed

Quick access panel → Color calibration description (null) #9308

ghost opened this issue Jun 22, 2021 · 6 comments · Fixed by #8078
Labels
bug: wip someone is currently working on that, check with them before taking over scope: UI user interface and interactions
Milestone

Comments

@ghost
Copy link

ghost commented Jun 22, 2021

  1. Run latest git dt build
  2. Open any file in editing mode
  3. Hover color calibration widget in quick access panel

Problem: Widget description shows "(null)" instead of something more sensible (or, don't show it at all, if description is not available for that widget).

@ghost ghost changed the title Quick access panel → Color calibration description Quick access panel → Color calibration description (null) Jun 22, 2021
@dterrahe
Copy link
Member

Not sure which color calibration widget you mean exactly, but this issue was probably already fixed in #8078 (as part of a reworking of some aspects of the QAP) which is scheduled to be merged into master early after the release of 3.6.

@ghost
Copy link
Author

ghost commented Jun 22, 2021

Not sure which color calibration widget you mean

Darkroom mode → Quick access panel → Color calibration → Temperature slider → Hover with mouse pointer → Popup contains "(null)" as a description.

@ghost
Copy link
Author

ghost commented Jun 23, 2021

Looks like popup drawing function is lacking for simple null value check and tries it anyway (temperature slider in color calibration module doesn't provide description for temperature slider). Probably in src/libs/modulegroups.c

@johnny-bit johnny-bit added this to the 3.8 milestone Jun 23, 2021
@AlicVB
Copy link
Contributor

AlicVB commented Jun 23, 2021

@dterrahe : do you prefer me to fix that now or we wait for your work to land ? I don't want to complicate things for you more than needed (and that's not really a critical issue)

@dterrahe
Copy link
Member

This is already fixed in #8078 and @TurboGit is planning to merge that before anything else (unless he finds a heap of problems, presumably) so there's no point creating a separate PR to just address this.

@AlicVB
Copy link
Contributor

AlicVB commented Jun 23, 2021

thanks ! I'm aware that it's already fixed in your PR and that we plan to merge that really early. That's why I've asked ;)

@johnny-bit johnny-bit added bug: wip someone is currently working on that, check with them before taking over scope: UI user interface and interactions labels Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: wip someone is currently working on that, check with them before taking over scope: UI user interface and interactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants