Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mouse over in preview area moves the section #9816

Closed
MStraeten opened this issue Aug 16, 2021 · 3 comments · Fixed by #9828
Closed

mouse over in preview area moves the section #9816

MStraeten opened this issue Aug 16, 2021 · 3 comments · Fixed by #9828
Labels
bug: pending someone needs to start working on that scope: UI user interface and interactions
Milestone

Comments

@MStraeten
Copy link
Collaborator

MStraeten commented Aug 16, 2021

When zooming in the selection frame is floating around along to mouse movments after an initial dragging in the preview.
It needs pressing a key thats not defined to be used with mouse movements (e.g. Esc key) to leave the preview area without changing the selection frame.

To Reproduce

  1. Use current master
  2. open image in darkroom and zoom in
  3. place mouse pointer in preview area
  4. move around without pressing a button
  5. the selection frame follows your mouse

Which commit introduced the error
t.b.d

Platform

  • darktable version : current master 3.7.0+833~g307903a2a
  • OS : Win10, also OSX
@johnny-bit johnny-bit added bug: pending someone needs to start working on that scope: UI user interface and interactions labels Aug 16, 2021
@MStraeten
Copy link
Collaborator Author

MStraeten commented Aug 16, 2021

bisecting done:

ff2f1d566f84278580d8469a53fc1945f3e3b6a5 is the first bad commit
commit ff2f1d566f84278580d8469a53fc1945f3e3b6a5
Author: Diederik ter Rahe <dterrahe@yahoo.com>
Date:   Sat Aug 7 13:39:28 2021 +0100

    shortcut tooltips and visual mapping for navigation and histogram

 src/libs/histogram.c  | 4 ++++
 src/libs/navigation.c | 2 ++
 2 files changed, 6 insertions(+)

--> #9747

@dterrahe
Copy link
Member

Wow. "Interesting" side effect of setting GDK_ENTER_NOTIFY_MASK (which is needed to change the mouse cursor when entering the navigation widget in mapping mode to indicate you can assign a shortcut). For me this only happens after I press the mouse in the widget at least once. But then it doesn't stop. I'm investigating...

@dterrahe
Copy link
Member

Used gtk_widget_set_events instead of gtk_widget_add_events. #9828 fixes.

@johnny-bit johnny-bit added this to the 3.8 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: pending someone needs to start working on that scope: UI user interface and interactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants