Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contradictory advice in diffuse or sharpen module #412

Closed
mbaz opened this issue Jan 18, 2022 · 5 comments
Closed

Contradictory advice in diffuse or sharpen module #412

mbaz opened this issue Jan 18, 2022 · 5 comments
Labels
no-issue-activity No activity on this issue

Comments

@mbaz
Copy link

mbaz commented Jan 18, 2022

The Diffuse or Sharpen module docs (https://docs.darktable.org/usermanual/3.8/en/module-reference/processing-modules/diffuse/) has the following advice in different paragraphs:

  • Introduction: undo effect of anti-alias filter with a preset and by placing the module before input color profile (that is, fairly early in the pipe).
  • General advice: D or S should come after chromatic aberration, noise correction, black level correction and color calibration.
  • Using multiple instances for image reconstruction: suggests an order placing sensor and demosaic correction as the last D or S instance.

I think the manual could be improved by placing all discussion about module ordering in a single section, providing one suggested order, and maybe discussing when and why to deviate from it.

Previous discussion: https://discuss.pixls.us/t/recover-ooc-jpeg-detail-sharpness-from-raw-with-darktable/28911/56

@elstoc
Copy link
Contributor

elstoc commented Jan 19, 2022

@aurelienpierre can I have your input here please?

@github-actions
Copy link

This issue has not had any activity in the past 60 days and will be closed in 365 days if not updated.

@github-actions github-actions bot added the no-issue-activity No activity on this issue label Mar 21, 2022
@kanyck
Copy link

kanyck commented Sep 1, 2022

That concerns me, too. Guidelines are contradictory.

@github-actions github-actions bot removed the no-issue-activity No activity on this issue label Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

This issue has not had any activity in the past 60 days and will be closed in 365 days if not updated.

Copy link

github-actions bot commented Nov 2, 2023

This issue has not had any activity in the past year and has therefore been closed.

@github-actions github-actions bot closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity No activity on this issue
Projects
None yet
Development

No branches or pull requests

3 participants