New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HuffmanTable* stuff needs an overhaul #148
Comments
LebedevRI
added a commit
to LebedevRI/rawspeed
that referenced
this issue
Oct 29, 2018
This is basically a direct resurrection (copy of relevant pieces) from * RawSpeed/NikonDecompressor.{h,cpp} * RawSpeed/LJpegDecompressor.{h,cpp} back from it's state as of v3.0 tag, when the support for Nikon Lossy After Split raws was working fine... This will clearly need to undergo all the same evolution as the other code did, and probably be deduplicated back after darktable-org#148. But for now, a (long-overdue, almost 2 years) fix for a regression is more important than horrible duplicated code. This is indeed a second attempt. I did this initially back during 2891a92 but introduced a bug (that was later fixed by 1f42e28) which was causing mis-decoding, so i abandoned the initial attempt... Fixes darktable-org#129. Refs. darktable-org#100. Refs. https://redmine.darktable.org/issues/12209
Some more unstructured minddumps, after staring at all that code for some time:
It seems to me there are more layers of abstractions that are missing:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's still too tightly coupled.
There are two things there:
It isn't necessary that said symbol table actually contains Huffman Codes as per JPEG spec,
it only needs to satisfy the rules*
The text was updated successfully, but these errors were encountered: