Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canon EOS D30, Canon EOS D60: fix black areas #402

Closed
wants to merge 3 commits into from

Conversation

PeterWem
Copy link
Contributor

Corrected optical black reading for Canon EOS D60 to remove green cast at high ISO. Free raw sample in the link and also an explanation https://discuss.pixls.us/t/measure-black-and-white-levels/32082/11?u=peter

Also fine tuned black level reading for Canon EOS D30 by adding horisontal black level. This part is not as important as the one for Canon EOS D60. Free raw sample https://discuss.pixls.us/t/measure-black-and-white-levels/32082/4?u=peter

Corrected optical black reading for Canon EOS D60 to remove green cast at high ISO. Free raw sample in the link https://discuss.pixls.us/t/measure-black-and-white-levels/32082/11?u=peter
Also fine tuned black level reading for Canon EOS D30 by adding horisontal black level. Free raw sample https://discuss.pixls.us/t/measure-black-and-white-levels/32082/4?u=peter
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 59.72% // Head: 59.72% // No change to project coverage 👍

Coverage data is based on head (66f6dee) compared to base (4cf6c99).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #402   +/-   ##
========================================
  Coverage    59.72%   59.72%           
========================================
  Files          214      214           
  Lines        12960    12960           
  Branches      1810     1810           
========================================
  Hits          7741     7741           
  Misses        5075     5075           
  Partials       144      144           
Flag Coverage Δ
integration 47.56% <ø> (ø)
rpu_u 47.56% <ø> (ø)
unittests 21.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LebedevRI LebedevRI changed the title Update cameras.xml Canon EOS D30, Canon EOS D60: fix black areas Nov 21, 2022
@LebedevRI
Copy link
Member

How did you pick what the right black areas are?

@PeterWem
Copy link
Contributor Author

PeterWem commented Nov 23, 2022

How did you pick what the right black areas are?

I used dcraw to get a pgm file. Then I loaded the pgm file into GIMP and brightened the image.

This is from the top left corner
https://d2x313g9lpht1q.cloudfront.net/original/3X/2/f/2feff35b10d73e545d62cf7d8da0404664e59fec.png
I started reading vertical black area from 16 px due to the difference from 0-15 px.

Horizontal...perhaps I did wrong there. What is your opinion? I moved 12 px down and used 0 height. The top area is 100% black and grey and I don't want rawspeed to use that area at all.

Changed from Vertical x=0 to Vertical x=5 when the first 4 columns are not black.
@PeterWem PeterWem closed this by deleting the head repository May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants