Add Hasselblad uncompressed 3FR support #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmilos
changed the title
This was referenced May 2, 2023
Merged
LebedevRI
reviewed
May 3, 2023
| @@ -44,7 +44,7 @@ HasselbladDecompressor::HasselbladDecompressor(const RawImage& mRaw_, | |||
|
|
|||
| // FIXME: could be wrong. max "active pixels" - "100 MP" | |||
| if (mRaw->dim.x == 0 || mRaw->dim.y == 0 || mRaw->dim.x % 2 != 0 || | |||
| mRaw->dim.x > 12000 || mRaw->dim.y > 8816) { | |||
| mRaw->dim.x > 12000 || mRaw->dim.y > 8842) { | |||
There was a problem hiding this comment.
(nitpick) Like i said, this is adding support for uncompressed, why is it touching something else?
There was a problem hiding this comment.
I ended up not merging this part.
After the main change of this PR, no RPU sample fails with this error,
which leads me to believe this was superficial.
This is why i'm asking for small separate changes.
There was a problem hiding this comment.
In theory, the tethered download from camera will produce a compressed .FFF file of this size, but indeed, there is no such sample in RPU currently. Maybe @kkempter-getswift can supply one as well please?
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found in X1D, X1D II 50C and X2D 100C (all available on RPU).
Split from #463
Also bumps size checks to 12000 x 8842 to support both H6D-100 and X2D 100C sensors.